[flakiness] pytest - use rerunfailures for retries #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
added
the
skip-changelog
MCK 1.3.0 Release NotesNew FeaturesMulti-Architecture SupportWe've added comprehensive multi-architecture support for the kubernetes operator. This enhancement enables deployment on IBM Power (ppc64le) and IBM Z (s390x) architectures alongside
Bug Fixes
Other Changes
|
nammn
commented
Sep 1, 2025
| @@ -22,6 +22,7 @@ def test_replica_set_sts_exists(self): | |||
| sts = self.appsv1.read_namespaced_stateful_set("rs001-pv", self.namespace) | |||
| assert sts | |||
|
|
|||
| @pytest.mark.flaky(reruns=3, reruns_delay=2) | |||
There was a problem hiding this comment.
The statefulset might be ready and then quickly not. Its an intermittent error and we should retry here
[2025/08/29 20:27:31.171] FAILURE: assert 2 == 3
[2025/08/29 20:27:31.171] + where 2 = {'available_replicas': 2,\n 'collision_count': 0,\n 'conditions': None,\n 'current_replicas': 3,\n 'current_revision': 'rs001-pv-56c4dc5d86',\n 'observed_generation': 1,\n 'ready_replicas': 2,\n 'replicas': 3,\n 'update_revision': 'rs001-pv-56c4dc5d86',\n 'updated_replicas': 3}.ready_replicas
[2025/08/29 20:27:31.17
There was a problem hiding this comment.
nammn
changed the title
nammn
commented
Sep 1, 2025
docker/mongodb-kubernetes-tests/tests/multicluster/multi_cluster_backup_restore.py
Outdated
Show resolved
Hide resolved
…ubernetes into add-retries-pytest-dec
nammn
requested review from
lsierant and
mircea-cosbuc
and removed request for
lsierant
docker/mongodb-kubernetes-tests/tests/multicluster/multi_cluster_backup_restore.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the reliability of several end-to-end and integration tests in the MongoDB Kubernetes test suite by replacing custom retry logic with standardized pytest flakiness handling. The changes primarily remove manual retry loops from test cases and instead use the
pytest.mark.flakydecorator to automatically rerun flaky tests, making the code cleaner and more maintainable.Test stability improvements:
pytest.mark.flakydecorators to multiple test cases to automatically rerun tests on failure, replacing custom retry logic.e2e_replica_setande2e_replica_set_pvwhich is racy/flakyDependency and import adjustments:
pytestimports to test files to support the use of theflakymarker.Proof of Work
Checklist
skip-changeloglabel if not needed